Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion

From: katouknl <katouknl(at)oss(dot)nttdata(dot)com>
To: Suraj Khamkar <khamkarsuraj(dot)b(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion
Date: 2021-10-07 08:14:43
Message-ID: 617cc933f32d460c9a4f1e12e116de03@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Thank you for the review.

I wasn't quite sure where to start counting the characters,
but I used pgindent to properly format it, so hopefully everything is
okay.
Also, I sorted them in alphabetical order just to make it look prettier.
> * The below change crosses the 80-character limit in a line. Please
> maintain the same.
> - "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "ROLE");
> + "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "TRANSFORM FOR",
> "ROLE");

I made sure there is no whitespaces this time.
> * There are trailing whitespaces after
> COMPLETE_WITH_QUERY(Query_for_list_of_languages);.
> Remove these extra whitespaces.
> surajkhamkar(at)localhost:tab_comment$ git apply
> fix_tab_complete_comment.patch
> fix_tab_complete_comment.patch:38: trailing whitespace.
> COMPLETE_WITH_QUERY(Query_for_list_of_languages);
> warning: 1 line adds whitespace errors.

Best wishes,
Ken Kato

Attachment Content-Type Size
comment_tab_complete.patch text/x-diff 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2021-10-07 08:27:15 Re: storing an explicit nonce
Previous Message Michael Paquier 2021-10-07 07:49:10 Re: strange case of "if ((a & b))"