Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint

From: Chapman Flack <chap(at)anastigmatix(dot)net>
To: Arjan van de Ven <arjan(at)linux(dot)intel(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Japin Li <japinli(at)hotmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, mark(dot)dilger(at)enterprisedb(dot)com, andres(at)anarazel(dot)de, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH v2] src/port/snprintf.c: Optimize the common base=10 case in fmtint
Date: 2021-10-27 23:50:45
Message-ID: 6179E5D5.5060102@anastigmatix.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/27/21 18:18, Arjan van de Ven wrote:
> + /*
> + * Special case each of the possible base values (8, 10, 16) to
> avoid an
> + * expensive divide operation
> + * (the compiler will use a multiply, shift or boolean ops for this)
> + */

Was 'boolean' the intended word there? To me it is distinct from 'bitwise'.

Regards,
-Chap

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-10-28 01:41:43 Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto
Previous Message Mark Dilger 2021-10-27 22:21:43 Re: CREATEROLE and role ownership hierarchies