| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding |
| Date: | 2021-01-12 16:41:19 |
| Message-ID: | 615304C2-8BEE-465D-BE35-543E4587D61B@yandex-team.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> 12 янв. 2021 г., в 13:49, Noah Misch <noah(at)leadboat(dot)com> написал(а):
>
> What do you think of abandoning slru-truncate-t-insurance entirely? As of
> https://postgr.es/m/20200330052809.GB2324620@rfd.leadboat.com I liked the idea
> behind it, despite its complicating the system for hackers and DBAs. The
> TruncateMultiXact() interaction rendered it less appealing. In v14+, commit
> cd5e822 mitigates the kind of bugs that slru-truncate-t-insurance mitigates,
> further reducing the latter's value. slru-truncate-t-insurance does mitigate
> larger trespasses into unlink-eligible space, though.
I seem to me that not committing an insurance patch is not a mistake. Let's abandon slru-truncate-t-insurance for now.
>> Fix <slru-truncate-modulo-v6.patch> certainly worth backpatching.
>
> I'll push it on Saturday, probably.
Thanks!
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2021-01-12 16:43:28 | Re: libpq compression |
| Previous Message | Andrey Borodin | 2021-01-12 16:19:44 | Re: Yet another fast GiST build |