| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | dilipbalaut(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_get_wal_replay_pause_state() should not return 'paused' while a promotion is ongoing. |
| Date: | 2021-05-31 03:52:54 |
| Message-ID: | 613321d7-e629-90ac-1006-8f63b4713c8e@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/05/19 19:24, Fujii Masao wrote:
>
>
> On 2021/05/19 16:43, Kyotaro Horiguchi wrote:
>> +1 for adding some tests for pg_wal_replay_pause() but the test seems
>> like checking only that pg_get_wal_replay_pause_state() returns the
>> expected state value. Don't we need to check that the recovery is
>> actually paused and that the promotion happens at expected LSN?
>
> Sounds good. Attached is the updated version of the patch.
> I added such checks into the test.
>
> BTW, while reading some recovery regression tests, I found that
> 013_crash_restart.pl has "use Time::HiRes qw(usleep)" but it seems
> not necessary. We can safely remove that? Patch attached.
Barring any objections, I'm thinking to commit these two patches.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-05-31 04:01:24 | Re: Fdw batch insert error out when set batch_size > 65535 |
| Previous Message | Christophe Pettus | 2021-05-31 03:41:28 | Re: AWS forcing PG upgrade from v9.6 a disaster |