| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #16154: pg_ctl restart with a logfile fails sometimes (on Windows) |
| Date: | 2019-12-06 15:14:16 |
| Message-ID: | 6120.1575645256@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Alexander Lakhin <exclusion(at)gmail(dot)com> writes:
> If this file is still opened by the previous server shell (it can happen
> when the previous server instance has unlinked it's pid file, but it's
> CMD shell is still running), the next CMD start fails with the
> aforementioned error message.
Interesting. I wonder whether this explains all of the remaining
buildfarm failures of this sort that we've been seeing even after
0ba06e0bf.
> To fix this issue I propose the attached patch
> (fix_logfile_sharing_violation ).
This seems like a pretty ugly hack ... please at least make it
#ifdef WIN32, so that the rest of us don't have to deal with it.
Also, if I read it correctly, it causes a pre-existing logfile
to get truncated, which has never happened before. Mode "a"
would be a better choice.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2019-12-06 15:40:12 | Re: BUG #16154: pg_ctl restart with a logfile fails sometimes (on Windows) |
| Previous Message | Tomas Vondra | 2019-12-06 12:41:19 | Re: Memory leak (possibly connected to postgis) leading to server crash |