Re: automatically generating node support functions

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: automatically generating node support functions
Date: 2022-07-08 15:46:28
Message-ID: 611d2e93-6330-47fa-0970-72316aed50f2@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.07.22 15:52, Tom Lane wrote:
> I'll re-read the patch today, but how open are you to putting the
> struct attributes at the top? I'm willing to do the legwork.

I agree near the top would be preferable. I think it would even be
feasible to parse the whole thing if pgindent split it across lines. I
sort of tried to maintain the consistency with C/C++ attributes like
__attribute__ and [[attribute]], hoping that that would confuse other
tooling the least. Feel free to experiment further.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-08 15:49:47 Re: System catalog documentation chapter
Previous Message Bharath Rupireddy 2022-07-08 15:46:22 Re: Switching XLog source from archive to streaming when primary available