Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Xi Wang <xi(dot)wang(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()
Date: 2013-01-21 03:35:45
Message-ID: 6109.1358739345@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Xi Wang <xi(dot)wang(at)gmail(dot)com> writes:
> The correct NULL check should use `*newval'; `newval' must be non-null.

Great catch, will commit. (But first I'm looking through commit
2594cf0e to see if I made the same mistake anywhere else :-(.)

How did you find that, coverity or some such tool?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2013-01-21 03:36:33 Re: [WIP] pg_ping utility
Previous Message Tom Lane 2013-01-21 03:34:21 Re: [PATCH] Fix NULL checking in check_TSCurrentConfig()