Re: [PATCH] Expose port->authn_id to extensions and triggers

From: Jacob Champion <pchampion(at)vmware(dot)com>
To: "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "rjuju123(at)gmail(dot)com" <rjuju123(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Date: 2022-03-23 22:52:22
Message-ID: 60ce6b04f2e4049d04700730f1c439e325731dc4.camel@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2022-03-17 at 18:33 -0400, Tom Lane wrote:
> Yeah. It seems to me that putting the auth info into struct Port was
> a fairly random thing to do in the first place, and we are now dealing
> with the fallout of that.
>
> I think what we ought to do here is separate out the data that we think
> parallel workers need access to. It does not seem wise to say "workers
> can access fields A,B,C of MyPort but not fields X,Y,Z". I do not have
> a concrete proposal for fixing it though.

v6-0002 has my first attempt at this. I moved authn_id into its own
substruct inside Port, which gets serialized with the parallel key
machinery. (My name selection of "SharedPort" is pretty bland.)

Over time, we could move more fields into the shared struct and fill
out the serialization logic as needed, and then maybe eventually
SharedPort can be broken off into its own thing with its own
allocation. But I don't know if we should do it all at once, yet.

WDYT?

--Jacob

Attachment Content-Type Size
v6-0001-Add-API-to-retrieve-authn_id-from-SQL.patch text/x-patch 5.9 KB
v6-0002-Allow-parallel-workers-to-use-pg_session_authn_id.patch text/x-patch 12.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-03-23 22:54:15 Re: [PATCH] add relation and block-level filtering to pg_waldump
Previous Message Tomas Vondra 2022-03-23 22:41:48 Re: Column Filtering in Logical Replication