Re: tiny step toward threading: reduce dependence on setlocale()

On 8/15/24 12:55 AM, Jeff Davis wrote:
> This overlaps a bit with what Peter already proposed here:
>
> https://www.postgresql.org/message-id/4f562d84-87f4-44dc-8946-01d6c437936f%40eisentraut.org
>
> right?

Maybe I am missing something but not as far as I can see. It is related
but I do not see any overlap.

>> 0003-Remove-dubious-check-against-default-locale.patch
>>
>> This patch removes a check against DEFAULT_COLLATION_OID which I
>> thought
>> looked really dubious. Shouldn't this just be a simple check for if
>> the
>> locale is deterministic? Since we know we have a valid locale that
>> should be enough, right?
>
> Looks good to me. The code was correct in the sense that the default
> collation is always deterministic, but (a) Peter is working on non-
> deterministic default collations; and (b) it was a redundant check.

Suspected so.

I have attached a set of rebased patches with an added assert. Maybe I
should start a new thread though.

Andreas