From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: libpq host/hostaddr/conninfo inconsistencies |
Date: | 2019-02-21 01:12:55 |
Message-ID: | 607.1550711575@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Robert, any chance you could opine on the doc patch, given that's your
>> suggested direction?
> I find it to be a more change than we really need, and I'm not sure
> how much it helps to clarify the issue at hand. Here is a simpler
> change which seems like it might do the trick (or maybe not, let's see
> what others think).
My only complaint about this is that it makes it sound like you *must*
provide "host", even when giving "hostaddr":
- Numeric IP address of host to connect to. This should be in the
+ Numeric IP address that should be used for the server specified
+ by <literal>host</literal>. This should be in the
The second para explains the cases in which you actually do need to
provide "host", but I'm afraid that the first sentence will have
misled people enough that they won't get the point.
I don't think there's anything very wrong with the existing wording
of this sentence.
Robert's second and third changes seem fine, though.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-02-21 01:18:05 | Re: Delay locking partitions during INSERT and UPDATE |
Previous Message | Peter Geoghegan | 2019-02-21 00:56:31 | Re: amcheck verification for GiST |