Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Date: 2022-01-19 18:45:07
Message-ID: 606676.1642617907@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Anyway, I think possibly we can drop the bottom half of the loop
> (the part trying to fsync non-removed files) in favor of fsync'ing
> the directory afterwards. Thoughts?

Oh, scratch that --- *this* loop doesn't care about the file
contents, but other code does. However, don't we need a directory
fsync too? Or is that handled someplace else?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-19 19:07:35 Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Previous Message Tom Lane 2022-01-19 18:34:21 Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work