From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Bernd Helmle <mailings(at)oopsware(dot)de> |
Subject: | Re: boolean in C |
Date: | 2009-07-16 14:17:51 |
Message-ID: | 6061.1247753871@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> writes:
> On 16 Jul 2009, at 14:53, Peter Eisentraut wrote:
>>>> the standard does not promise that type _Bool has size = 1 byte.
>>>> We have to have that because of on-disk compatibility requirements.
>>> I think the latter is easily fixable, or forceable to be one byte.
>> How do you plan to do that?
> by casting it to 1 byte type such as char ?
That's hardly going to improve readability for anyone. Also, it will
flat out not work for the catalog struct declarations. When we say
"bool relhasindex;" the compiler had better think that that's a
one-byte field.
> And it is pretty annoying, when your product also has its own BOOLean
> defined...
IOW you're not using stdbool either?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2009-07-16 14:30:12 | Re: Mostly Harmless: c++bookends - patch 2 of 4 |
Previous Message | Andrew Gierth | 2009-07-16 14:17:30 | revised hstore patch |