| From: | Shayon Mukherjee <shayonj(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal to Enable/Disable Index using ALTER INDEX (with patch) |
| Date: | 2024-10-16 18:15:51 |
| Message-ID: | 6060730B-DFEA-4913-A696-99AFE61DC2BE@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 16, 2024, at 12:19 PM, Shayon Mukherjee <shayonj(at)gmail(dot)com> wrote:
>
> - ALTER INDEX ... ENABLE/DISABLE performs an in-place update of the pg_index
> catalog to protect against indcheckxmin [2] (older unrelated thread).
Performing the in place update of the pg_index row from ATExecEnableDisableIndex using systable_inplace_update_begin was failing in CI weirdly but not on my local MacBook when running spec suite. I am also wondering what is causing the requirement [1] to update the row in-place vs say using CatalogTupleUpdate since using the later is working well locally + CI?
I have attached a v2 patch (following from the last v1 patch [1]) that uses CatalogTupleUpdate and local + CI [2] is passing.
[1] https://www.postgresql.org/message-id/20180618215635.m5vrnxdxhxytvmcm@alap3.anarazel.de
[2] https://www.postgresql.org/message-id/EF2313B8-A017-4869-9B7F-A24EDD8795DE%40gmail.com
[3] https://github.com/shayonj/postgres/pull/1
Thanks
Shayon

| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-10-16 18:17:58 | Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR) |
| Previous Message | Shubham Khanna | 2024-10-16 18:03:35 | Re: Pgoutput not capturing the generated columns |