From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, brown(at)fastmail(dot)com, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: BUG #13741: vacuumdb does not accept valid password |
Date: | 2015-12-23 16:44:53 |
Message-ID: | 6048.1450889093@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Mon, Nov 16, 2015 at 11:41 AM, Haribabu Kommi
> <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>> On Sun, Nov 15, 2015 at 12:39 AM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> That's neater. See for example the attached.
>> Yes, it is much cleaner than the previous version.
>> I reviewed and tested the same. It is working for all scenarios.
> This patch has fallen in the void and it simplifies greatly vacuumdb.c
> and its password-related routines. I have added it to the next CF to
> not forget about it:
Sorry for having lost track of this. I think if we're going to do this,
we should do it now not later, because it essentially reverts the
connectDatabase() API change made in 83dec5a71 in favor of a different API
change with the same purpose. Now, that doesn't matter if no third-party
code is using connectDatabase(), but I have a suspicion that there
probably is some. Any such users will not thank us for whacking
connectDatabase's API around in 9.5 and then whacking it around
differently in 9.6.
In short, I think we should apply this now and back-patch into 9.5,
like the prior patch, even though we're post-RC1. The reduction in
cross-version API churn is worth it.
If no objections, I'll go do that shortly.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-12-23 16:55:44 | Re: BUG #13741: vacuumdb does not accept valid password |
Previous Message | foggyglass | 2015-12-23 14:55:46 | BUG #13830: pg_table_size and pg_indexes_size |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-12-23 16:55:44 | Re: BUG #13741: vacuumdb does not accept valid password |
Previous Message | Robert Haas | 2015-12-23 16:27:54 | Re: pgbench --latency-limit option |