Re: PGXS: REGRESS_OPTS=--load-language=plpgsql

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: "David E(dot) Wheeler" <david(at)kineticode(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dimitri Fontaine <dfontaine(at)hi-media(dot)com>, Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, David Fetter <david(at)fetter(dot)org>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PGXS: REGRESS_OPTS=--load-language=plpgsql
Date: 2010-02-20 21:59:56
Message-ID: 603c8f071002201359i2af0d3b3r1ca69fdce371d159@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 20, 2010 at 2:51 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> David E. Wheeler wrote:
>> On Feb 20, 2010, at 11:03 AM, Bruce Momjian wrote:
>>
>> >> There is also the "must fix" issue with pg_regress.
>> >
>> > Why?  My pg_regress runs just fine.  If you are talking about 3rd party
>> > modules, I suggested conditional Makefile rules.
>>
>> Because you can either make the simple change to pg_regress that
>> David Fetter sent yesterday and have things continue to work,
>> or you can break a slew of third-party module test suites (and
>> possibly modules, as well) and make a lot of other people do a
>> lot more work, not to mention email -hackers and ask WTF happened
>> because they may well not know.
>>
>> I think that not changing pg_regress is more work for third-party
>> module maintainers *and* more work for the Pg community when
>> those maintainers come asking what happened and for advice on
>> how to fix it.
>
> Well, I was asking why you labeled it "must fix" rather than "should
> fix".  I am fine with the pg_regress.c change.

Yeah, if it makes life easier for other people, I say we go for it.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-02-20 22:03:09 Re: scheduler in core
Previous Message Merlin Moncure 2010-02-20 21:41:41 Re: scheduler in core