Re: [PATCH] Provide rowcount for utility SELECTs

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Boszormenyi Zoltan <zb(at)cybertec(dot)at>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Date: 2010-02-12 18:38:11
Message-ID: 603c8f071002121038t211829b9n844888411294064@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 12, 2010 at 1:22 PM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
> Robert Haas írta:
>> On Fri, Feb 12, 2010 at 10:48 AM, Boszormenyi Zoltan <zb(at)cybertec(dot)at> wrote:
>>
>>> I added a small change to protocol.sgml for the
>>> "CommandComplete" message describing the change.
>>> Is it enough?
>>>
>>
>> Ah, I didn't even see that that section needed to be updated.  Good
>> catch.  I'd suggest the following wording:
>>
>> For a <command>SELECT</command> or <command>CREATE TABLE AS</command>
>> command, the tag is SELECT rows... [and the rest as you have it]
>>
>> We should probably also retitle that section from "Retrieving Result
>> Information for Other Commands" to "Retrieving Other Result
>> Information" and adjust the text of the opening sentence similarly.
>>
>> Also I think you need to update the docs for PQcmdtuples to mention
>> that it not works for SELECT and CTAS.
>>
>
> Ok, I will update libpq.sgml where this section resides.
> What's a CTA, btw? Do you mean CTE, a.k.a. "Common Table Expression"?

Sorry, CTAS = CREATE TABLE AS SELECT.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2010-02-12 18:55:36 Re: [PATCH] Provide rowcount for utility SELECTs
Previous Message Boszormenyi Zoltan 2010-02-12 18:29:08 Re: [PATCH] Provide rowcount for utility SELECTs