| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Provide rowcount for utility SELECTs |
| Date: | 2010-02-11 19:42:49 |
| Message-ID: | 603c8f071002111142r6e893810j571e8a2fbf260173@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 11, 2010 at 2:38 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Robert Haas escribió:
>
>> I was all prepared to admit that I hadn't actually looked at the patch
>> carefully enough, but I just looked at (and CVS HEAD) again and what
>> you've written here doesn't appear to describe what I'm seeing in the
>> code:
>>
>> if ((portal->strategy != PORTAL_ONE_SELECT) && (!portal->holdStore))
>> FillPortalStore(portal, isTopLevel);
>>
>> So one of us is confused... it may well be me.
>
> Ah, it seems I misread it ... but then I don't quite see the point in
> that change.
Well the point is just that Zoltan is adding some more code that
applies to both branches of the switch, so merging them saves some
duplication.
> Well, not doing a full review anyway, so never mind me.
Actually I was sort of hoping you (or someone other than me) would
pick this up for commit...
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Garick Hamlin | 2010-02-11 19:45:13 | Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL |
| Previous Message | Robert Haas | 2010-02-11 19:40:51 | Re: log_error_verbosity function display |