| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org, pgsql-performance(at)postgresql(dot)org, Michael Clemmons <glassresistor(at)gmail(dot)com>, Hannu Krosing <hannu(at)2ndquadrant(dot)com>, Scott Marlowe <scott(dot)marlowe(at)gmail(dot)com> |
| Subject: | Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) |
| Date: | 2010-02-02 18:14:40 |
| Message-ID: | 603c8f071002021014h4b489f44s9014377e1b38dbc7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-performance |
On Tue, Feb 2, 2010 at 12:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> On Tuesday 02 February 2010 18:36:12 Robert Haas wrote:
>>> I took a look at this patch today and I agree with Tom that
>>> pg_fsync_start() is a very confusing name. I don't know what the
>>> right name is, but this doesn't fsync so I don't think it shuld have
>>> fsync in the name. Maybe something like pg_advise_abandon() or
>>> pg_abandon_cache(). The current name is really wishful thinking:
>>> you're hoping that it will make the kernel start the fsync, but it
>>> might not. I think pg_start_data_flush() is similarly optimistic.
>
>> What about: pg_fsync_prepare().
>
> prepare_for_fsync()?
It still seems mis-descriptive to me. Couldn't the same routine be
used simply to abandon undirtied data that we no longer care about
caching?
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2010-02-02 18:25:21 | Re: Using the new libpq connection functions in PostgreSQL binaries |
| Previous Message | Tom Lane | 2010-02-02 17:50:15 | Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mridula Mahadevan | 2010-02-02 18:17:15 | Queries within a function |
| Previous Message | Tom Lane | 2010-02-02 17:50:15 | Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) |