| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | unfathomable comment in psqlscan.l |
| Date: | 2010-01-26 18:35:08 |
| Message-ID: | 603c8f071001261035i5ff4a8das6a0ed1d2786dba6c@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While reviewing Pavel's patch for variable quoting in psql, I came
upon the following comment in psqlscan.l:
/*
* The variable value is just emitted without any
* further examination. This is consistent with the
* pre-8.0 code behavior, if not with the way that
* variables are handled outside backslash commands.
*/
I cannot figure out for the life of me what this is referring to. It
seems to date back to 2004, when the old psql lexer was rewritten to
use flex. But I can't figure out what "further examination" someone
might have expected, or how it's inconsistent with the how things are
"handled outside backslash commands".
Help?
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-01-26 18:38:37 | Re: Review: listagg aggregate |
| Previous Message | Josh Berkus | 2010-01-26 18:33:20 | Re: Dividing progress/debug information in pg_standby, and stat before copy |