From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alex Hunsaker <badalex(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: attoptions |
Date: | 2010-01-22 18:04:43 |
Message-ID: | 603c8f071001221004i24ffd1daweb1c508c570cc8e5@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jan 21, 2010 at 10:24 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
> On Thu, Jan 21, 2010 at 07:30, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Thu, Jan 21, 2010 at 12:57 AM, Alex Hunsaker <badalex(at)gmail(dot)com> wrote:
>>> Seems to me a comment about the above might be nice. Something like
>>> /* Things after here are should always be default null */ in
>>> pg_attribute.h ?
>>
>> Well... that wouldn't actually be a correct summary, so no. The point
>> is that variable-length fields are not used in tuple descriptors.
>> I'll add a comment about that.
>
> Yes that sounds much better, I was struggling to find the words. What
> I was trying to express was something along the lines of you cant have
> a non null value after these because you cant statically initialize
> them in genbki.
Committed. Thanks for the very thorough review.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-01-22 18:09:28 | Re: About "Our CLUSTER implementation is pessimal" patch |
Previous Message | Leonardo F | 2010-01-22 17:56:55 | Re: About "Our CLUSTER implementation is pessimal" patch |