| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: quoting psql varible as identifier |
| Date: | 2010-01-15 01:46:47 |
| Message-ID: | 603c8f071001141746l414b519fg6e22c32dae2e0c1a@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 11, 2010 at 6:54 AM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> No longer applies, please rebase.
>
> fixed, sorry
Hmm. I think that pqEscapeIdentConn should be in a separate section
of the documentation, entitled "Escaping Identifiers for Inclusion in
SQL Commands". Or else we should merge the existing sections
"Escaping Strings for Inclusion in SQL Commands" and "Escaping Binary
Strings for Inclusion in SQL Commands" and then put this in there too.
On a perhaps-related note, does anyone understand why "Escaping
Strings for Inclusion in SQL Commands" is formatted in a way that is
needlessly inconsistent with the preceding and following sections? I
was surprised by the magnitude of the doc diff hunk in this patch, but
when I looked at it it seems to read more clearly with these changes.
I have yet to fully review the code but on a quick glance it looks reasonable.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-01-15 01:49:26 | Re: KNNGiST for knn-search (WIP) |
| Previous Message | KaiGai Kohei | 2010-01-15 00:56:10 | Re: [PATCH] remove redundant ownership checks |