Re: point_ops for GiST

2010/1/11 Teodor Sigaev <teodor(at)sigaev(dot)ru>:
>> I have reviewed this patch and it looks good to me.  The only
>> substantive question I have is why gist_point_consistent() uses a
>> different coding pattern for the box case than it does for the polygon
>> and circle cases?  It's not obvious to me on the face of it why these
>> aren't consistent.
>
> gist_circle_consistent/gist_poly_consistent set recheck flag to true because
> corresponding index contains only bounding box of indexed values
> (circle/polygon). gist_point_consistent could do an exact check. Will add a
> coments.

Make sense. A comment sounds good.

>> Beyond that, I have a variety of minor whitespace and commenting
>> suggestions, so I am attaching an updated version of the patch as well
>
> Agree with your changes. Suppose, there is no objection to commit it?

No, I think it looks good... if no one else chimes in with objections
in the next day or two I would go ahead.

...Robert