Re: Feature patch 1 for plperl [PATCH]

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Feature patch 1 for plperl [PATCH]
Date: 2010-01-10 21:35:46
Message-ID: 603c8f071001101335j58aebb1aqfe29c482ea02560d@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 10, 2010 at 2:58 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I don't know why you would do either of these things. I at least would load
> one module which would in turn load others. So I'd expect to see something
> like this:
>
>   plperl.on_perl_init = 'use lib "/my/app"; use MyApp::Pg;'
>
> I think the suggestion that somehow people will want to put a huge list of
> directives straight into postgresql.conf and that this is a reason not to
> provide this facility is on the wrong track completely.

Hmm. I have to admit I didn't think about "use lib". That does seem
like a plausible thing to want to do.

>> I would strongly suggest to Tim that he rip the portions of this patch
>> that are related to this feature out and submit them separately so
>> that we can commit the uncontroversial portions first.
>
> See my previous email. I suggested that Tim send three patches: one for this
> controversial stuff, one for the new utility functions for plperl, and one
> for the remainder. He and I have discussed it and I believe he is agreeable
> to that.

OK, well then just +1 for that.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-01-10 21:54:39 Re: [PATCH] remove redundant ownership checks
Previous Message Robert Haas 2010-01-10 21:30:07 Re: [PATCH] remove redundant ownership checks