| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting |
| Date: | 2010-01-05 03:42:30 |
| Message-ID: | 603c8f071001041942k551ec54chafb8d69022929c6e@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Jan 4, 2010 at 9:34 PM, Tom Lane <tgl(at)postgresql(dot)org> wrote:
> Log Message:
> -----------
> Remove too-smart-for-its-own-good optimization of not overwriting the output
> files when they haven't changed. This confuses make because the build fails
> to update the file timestamps, and so it keeps on doing the action over again.
This doesn't seem like a good idea. Not rebuilding the output files
also saves recompiling the things that depend on them. For the BKI
files thast doesn't matter much, but for schemapg.h it might be
significant. Certainly, if we move to generating more header files
this way, it WILL be significant. If running the script is cheap (and
it should be), it's better to take that hit rather than recompiling a
whole mess of .c files unnecessarily.
...Robert
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-01-05 03:51:34 | Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting |
| Previous Message | Andrew Dunstan | 2010-01-05 02:34:07 | Re: pgsql: Get rid of the need for manual maintenance of the initial |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takahiro Itagaki | 2010-01-05 03:44:38 | Re: Verifying variable names in pgbench |
| Previous Message | Robert Haas | 2010-01-05 03:33:47 | Re: Verifying variable names in pgbench |