Re: parse_oper cache

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: parse_oper cache
Date: 2009-12-27 19:57:56
Message-ID: 603c8f070912271157g7e30f188kee8a8ef6c6ab4d9e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 27, 2009 at 2:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> it does make me wonder whether there's any point in retaining
>> CacheMemoryContext at all.
>
> Well, as per backend/utils/mmgr/README:
>
>  CacheMemoryContext --- permanent storage for relcache, catcache, and
>  related modules.  This will never be reset or deleted, either, so it's
>  not truly necessary to distinguish it from TopMemoryContext.  But it
>  seems worthwhile to maintain the distinction for debugging purposes.
>
> I'm not sure about the word "maintain" here; I can't recall whether
> there was any comparable concept before we invented the memory context
> mechanism.  But I still think it's useful to distinguish cache activity
> from generic permanent memory allocations.

If we're really doing it, sure. But putting half of it in
TopMemoryContext and the other half in CacheMemoryContext is not
obviously of any value.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-27 20:03:31 Re: parse_oper cache
Previous Message Tom Lane 2009-12-27 19:45:47 Re: parse_oper cache