Re: [patch] executor and slru dtrace probes

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bernd Helmle <mailings(at)oopsware(dot)de>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)sun(dot)com>, pgsql-hackers(at)postgresql(dot)org, Robert(dot)Lor(at)sun(dot)com, jesus(at)omniti(dot)com
Subject: Re: [patch] executor and slru dtrace probes
Date: 2009-12-14 12:49:34
Message-ID: 603c8f070912140449o23892042kc94a31cff6f67fa5@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 14, 2009 at 7:19 AM, Bernd Helmle <mailings(at)oopsware(dot)de> wrote:
> --On 10. Dezember 2009 16:49:50 +0100 Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
> wrote:
>
>> You need to determine which SLRU is used. Because SLRUs are initialized
>> during startup  pointer should be same in all backends. If I think more
>> about it. Maybe it could be goot to add probe also into SimpleLruInit to
>> catch name of SLRUs.
>
> Hi Zdenek,
>
> do you plan to work on this further? I was about to mark the SLRU probes as
> ready for committer...

Since the author has pretty much admitted he didn't fix any of the
issues that were raised by the last committer review, I'm a little
confused about why you're asking for another one.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2009-12-14 12:50:28 Re: [PATCH] ACE Framework - Database, Schema
Previous Message Simon Riggs 2009-12-14 12:47:51 Re: Hot Standby, release candidate?