From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: TODO item: Allow more complex user/database default GUC settings |
Date: | 2009-09-21 15:08:05 |
Message-ID: | 603c8f070909210808n5c4f418clcf7ce3be9ae2fda3@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 21, 2009 at 12:21 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Robert Haas escribió:
>
>> > Here's a first shot on this for my current review round. Patch needed to
>> > re-merged into current CVS HEAD due to some merge conflicts, i've also
>> > adjusted the regression tests (minor). On a first look, i like the patch
>> > (especially the code for the utility commands accessing the settings is
>> > better modularized now, which looks much nicer).
>>
>> So is this ready to commit, or what?
>
> Not really :-( It needs some minor tweaks to qualify as a cleanup
> patch, and further extra coding for there to be an actual new feature.
So here's the followup question - do you intend to do one of those
things for this CommitFest, or should we mark this as Returned with
Feedback once Bernd posts the rest of his review?
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-09-21 15:59:45 | Re: generic copy options |
Previous Message | Heikki Linnakangas | 2009-09-21 14:46:06 | Re: Resjunk sort columns, Heikki's index-only quals patch, and bug #5000 |