From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Greg Stark <gsstark(at)mit(dot)edu>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: autogenerating headers & bki stuff |
Date: | 2009-07-27 03:05:05 |
Message-ID: | 603c8f070907262005pc809f34nf472d5e6ec485c49@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jul 26, 2009 at 8:46 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Introducing defaults for DATA() would bring some benefits because it
>> would mostly avoid the need to change every row in the file when
>> adding a new column. But a preprocessing script can do much more
>> sophisticated transformations, like computing a value for a column, or
>> looking up type names in another file and translating them into OIDs.
>
> Hmm. A preprocessing script that produces DATA commands might in fact
> be a reasonable proposal, but it was not what I understood you to be
> suggesting before.
OK, sorry if I was unclear. I'm not sure exactly what you mean by
producing DATA() commands; I think the output should be BKI directly.
One of the things this patch does that I think is good (however flawed
it may be otherwise) is unifies all of the stuff that needs to parse
the DATA() statements into a single script. I think this is something
we should pursue, because I think it will simplify the introduction of
any other notation we want to consider in this area (regardless of
whether it's DATA_DEFAULTS or EXEC_BKI or what have you).
Maybe I should rip out all the anum.h stuff (sniff, I'm sad, I liked
that design...) and resubmit.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-07-27 03:21:34 | Re: Merge Append Patch merged up to 85devel |
Previous Message | Itagaki Takahiro | 2009-07-27 02:54:59 | Re: BUG #4941: pg_stat_statements crash |