Re: WIP: Column-level Privileges

From: "Robert Haas" <robertmhaas(at)gmail(dot)com>
To: "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Markus Wanner" <markus(at)bluegap(dot)ch>, "PostgreSQL-development Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: Column-level Privileges
Date: 2008-12-03 01:48:07
Message-ID: 603c8f070812021748m3f4cbc94h9ca0be3092f20885@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 25, 2008 at 4:03 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Alvaro Herrera (alvherre(at)commandprompt(dot)com) wrote:
>> I had a look at aclchk.c and didn't like your change to
>> objectNamesToOids; seems rather baroque. I changed it per the attached
>> patch.
>
> I've incorporated this change.
>
>> Moreover I didn't very much like the way aclcheck_error_col is dealing
>> with two or one % escapes. I think you should have a separate routine
>> for the column case, and prepend a dummy string to no_priv_msg.
>
> I can do this, not really a big deal.

Stephen,

Are you sending an updated patch with these minor changes?

...Robert

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-12-03 01:50:50 Re: Erroring out on parser conflicts
Previous Message Tom Lane 2008-12-03 01:06:05 Re: [PATCHES] GIN improvements