From: | "Robert Haas" <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Decibel! <decibel(at)decibel(dot)org>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, "Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Is autovacuum too noisy about orphan temp tables? |
Date: | 2008-10-15 20:18:45 |
Message-ID: | 603c8f070810151318w1c9a7cd6r2e5363d77004849f@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Oct 15, 2008 at 11:29 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Decibel! <decibel(at)decibel(dot)org> writes:
>> Since this is something that's not supposed to happen, making it a
>> WARNING might be appropriate too...
>
> Uh, the complaint was that the message is too noisy, not that it isn't
> noisy enough.
I think you're confusing the volume of the noise with the frequency of
the noise. Once a minute is too often to spit out a message like this
regardless of the log level, but at least at a higher log level
someone may have a better chance of noticing before the disk fills up.
A much better solution would be to not print the warning every time.
I think the right solution is to do exactly what you rejected
upthread, namely adding some kind of stack to track the last time this
was printed. It doesn't need to be real granular, or real exact.
Don't track each table separately, just add a static integer. If a
particular autovac run sees the problem at least once, increment the
integer and print out warnings for all tables found in that run if
(variable % 60) == 1.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2008-10-15 20:46:04 | Re: The Axe list |
Previous Message | Jeff Davis | 2008-10-15 19:58:16 | Re: Deriving Recovery Snapshots |