Re: patch: Add columns via CREATE OR REPLACE VIEW

From: "Robert Haas" <robertmhaas(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Gregory Stark" <stark(at)enterprisedb(dot)com>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "PostgreSQL-development Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch: Add columns via CREATE OR REPLACE VIEW
Date: 2008-08-07 22:38:04
Message-ID: 603c8f070808071538y1934877aq23b3a4b2d42d21c0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Forgot to copy my response to this to the list.

On Thu, Aug 7, 2008 at 5:26 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Robert Haas" <robertmhaas(at)gmail(dot)com> writes:
>> Although several people have said that they prefer the idea of using
>> ALTER VIEW to make changes to views, no one has really expanded on the
>> reasons for their preference.
>
> Because it sidesteps the problem of tracking which column is supposed to
> be which. If you try to do it through CREATE OR REPLACE VIEW, you have
> to either be extremely restrictive (like probably not allow renaming
> of columns at all), or write some AI-complete algorithm to guess at what
> the user intended.

The current code takes the approach of being extremely restrictive -
it doesn't let you change anything at all. The code I'm proposing
manages to relax that restriction without creating any ambiguity that
anyone has been able to point out. All of the ambiguities that have
been mentioned are problems that might be created by some other,
entirely hypothetical patch.

...Robert

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Gierth 2008-08-07 22:49:48 Re: bug in prepared statements, alter table <8.3
Previous Message Merlin Moncure 2008-08-07 22:30:10 bug in prepared statements, alter table <8.3