From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
Cc: | Greg Stark <gsstark(at)mit(dot)edu>, Michael Paesold <mpaesold(at)gmx(dot)at>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plperl vs LC_COLLATE (was Re: Possible savepoint bug) |
Date: | 2006-01-09 17:06:33 |
Message-ID: | 6030.1136826393@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> I don't know. Reading that code just makes my head spin ...
Yeah, too many ifdefs :-(. But I suppose that the initial
"#ifdef LOCALE_ENVIRON_REQUIRED" block is not compiled on sane
platforms, meaning that the first code in the routine is the
unconditional
if (! setlocale(LC_ALL, ""))
setlocale_failure = TRUE;
> I should have thought a library shouldn't make too many assumptions
> about locale settings anyway.
Indeed; I think a pretty strong case can be made that this is a Perl
bug. It's reasonable to be doing the setlocale call in a standalone
Perl executable, but libperl should just work with whatever locale
settings have been chosen by the surrounding program (ie, all these
calls should be setlocale(LC_xxx, NULL) in the libperl case).
> I'm just about out of ideas and right out of time to spend on this.
We could just file a Perl bug report and wait for them to fix it.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Neil Conway | 2006-01-09 17:17:25 | Re: lookup_rowtype_tupdesc considered harmful |
Previous Message | Jim Buttafuoco | 2006-01-09 16:46:49 | Re: Fw: Is anyone interested in getting PostgreSQL working |