| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench - minor fix for meta command only scripts |
| Date: | 2016-07-12 20:59:23 |
| Message-ID: | 6016.1468357163@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
> Ok. Here is an updated version, with a better suffix and a simplified
> comment.
Doesn't this break the handling of latency calculations, or at least make
the results completely different for the last metacommand than what they
would be for a non-last command? It looks like it needs to loop back so
that the latency calculation is completed for the metacommand before it
can exit. Seems to me it would probably make more sense to fall out at
the end of the "transaction finished" if-block, around line 1923 in HEAD.
(The code structure in here seems like a complete mess to me, but probably
now is not the time to refactor it.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-07-12 21:11:32 | Re: BUG #14245: Segfault on weird to_tsquery |
| Previous Message | David Kellum | 2016-07-12 20:54:53 | Re: BUG #14245: Segfault on weird to_tsquery |