Re: pgsql: Improve error messages for bytea decoding failures.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve error messages for bytea decoding failures.
Date: 2014-07-09 15:14:55
Message-ID: 6002.1404918895@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Improve error messages for bytea decoding failures.

Per style guide, errhints should be capitalized full sentences, ie

- errhint("input data is missing padding, truncated, or otherwise corrupted")));
+ errhint("Input data is missing padding, truncated, or otherwise corrupted.")));

Also, it's unwise to use %c on a value you aren't sure is an ASCII
character; that's likely to produce an invalidly-encoded error message,
which will *not* be an improvement of the user experience.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2014-07-09 15:29:58 Re: pgsql: Improve error messages for bytea decoding failures.
Previous Message Robert Haas 2014-07-09 15:05:26 pgsql: Improve error messages for bytea decoding failures.