| From: | Philip Warner <pjw(at)rhyme(dot)com(dot)au> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New warning in pg_dump |
| Date: | 2004-08-24 02:29:30 |
| Message-ID: | 6.1.1.1.0.20040824122830.0466bf40@203.8.195.10 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 01:58 AM 24/08/2004, Alvaro Herrera wrote:
>static int _isIdentChar(unsigned char c)
I think the correct thing to do is to leave it as (signed) char, and remove
the comparison to \200 = -127. All chars will be >= -127. I will fix this
in the next release.
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 03 5330 3172 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp.mit.edu:11371 |/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marc G. Fournier | 2004-08-24 02:39:33 | auto-casting a bit more intelligent in 8.0 ... ? |
| Previous Message | Philip Warner | 2004-08-24 02:23:58 | Re: compile warnings in HEAD |