| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: potential stuck lock in SaveSlotToPath() |
| Date: | 2020-03-25 10:13:19 |
| Message-ID: | 5ffa6f6d-cadd-64a9-5ab6-4362fb20ae93@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-03-20 16:38, Robert Haas wrote:
> On Fri, Mar 20, 2020 at 11:32 AM Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> On 2020-03-19 16:38, Robert Haas wrote:
>>> Incidentally, the wait-event handling in SaveSlotToPath() doesn't look
>>> right for the early-exit cases either.
>>
>> There appear to be appropriate pgstat_report_wait_end() calls. What are
>> you seeing?
>
> Oh, you're right. I think I got confused because the rename() and
> close() don't have that, but those don't have a wait event set either.
> Sorry for the noise.
Any concerns about applying and backpatching the patch I posted?
The talk about reorganizing this code doesn't seem very concrete at the
moment and would probably not be backpatch material anyway.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2020-03-25 10:32:05 | Re: truncating timestamps on arbitrary intervals |
| Previous Message | Justin Pryzby | 2020-03-25 10:12:29 | Re: error context for vacuum to include block number |