| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [18] Fix a few issues with the collation cache |
| Date: | 2024-08-14 23:30:23 |
| Message-ID: | 5ff36619c10413008356d1ffeb8a7fb100531249.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2024-08-08 at 12:24 -0700, Jeff Davis wrote:
> The collation cache, which maps collation oids to pg_locale_t
> objects,
> has a few longstanding issues:
Here's a patch set v2.
I changed it so that the pg_locale_t itself a resource kind, rather
than having separate locale_t and UCollator resource kinds. That
requires a bit more care to make sure that the pg_locale_t can be
initialized without leaking the locale_t or UCollator, but worked out
to be simpler overall.
A potential benefit of these changes is that, for eventual support of
multi-lib or an extension hook, improvements in the API here will make
things less error-prone.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Minor-refactor-of-collation-cache.patch | text/x-patch | 11.8 KB |
| v2-0002-Tighten-up-make_libc_collator-and-make_icu_collat.patch | text/x-patch | 6.9 KB |
| v2-0003-Refactor-collation-version-check-into-new-functio.patch | text/x-patch | 6.1 KB |
| v2-0004-For-collation-cache-use-CollationCacheContext-for.patch | text/x-patch | 5.3 KB |
| v2-0005-Use-resource-owners-to-track-locale_t-and-ICU-col.patch | text/x-patch | 4.5 KB |
| v2-0006-Invalidate-collation-cache-when-appropriate.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-08-14 23:36:57 | Re: Speed up Hash Join by teaching ExprState about hashing |
| Previous Message | Tom Lane | 2024-08-14 23:19:20 | Re: Opinion poll: Sending an automated email to a thread when it gets added to the commitfest |