Re: Support waffle>1.7.4

From: Christian Ullrich <chris(at)chrullrich(dot)net>
To: Craig Ringer <craig(at)2ndquadrant(dot)com>
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: Support waffle>1.7.4
Date: 2016-05-09 17:03:20
Message-ID: 5fb97533-b4c9-86c6-7ec2-d782b2155ac6@chrullrich.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

* Christian Ullrich wrote:

> * Craig Ringer wrote:

>> On 13 April 2016 at 01:51, Christian Ullrich <chris(at)chrullrich(dot)net
>> <mailto:chris(at)chrullrich(dot)net>> wrote:

>> other direction. Last November, waffle-jna 1.7.5 was released,
>> containing an incompatible API change that is also present in all
>> released 1.8 versions. The fix is simple; as far as the code goes,

>> I'm on hols this week but will try to get it sorted out next week.
>> Christian, if you send a github pull that passes tests and updates the
>> pom.xml I'll just merge it directly instead.

> Sorry. I'd be happy to do *that*, but it looks like that's not all there
> is to it. It would be easy if the waffle version was set in pgjdbc's

I did it myself after all; I hope the result looks somewhat sensible.

- https://github.com/pgjdbc/pgjdbc-parent-poms/pull/5
- https://github.com/pgjdbc/pgjdbc/pull/555

As for "that passes tests", achieving this was not difficult (other than
getting them to work at all, see my previous PRs from today) because
there are exactly zero tests for SSPI auth, or at least that is how many
I could find. What there is, passes.

I thought about writing a few, and I may yet get around to that, but
then I collided head-on with Maven and had to sedate the Java part of my
brain.

--
Christian

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Christian Ullrich 2016-05-09 23:49:21 Re: Support waffle>1.7.4
Previous Message David G. Johnston 2016-05-07 19:10:01 Re: org.postgresql.util.PSQLException: ERROR: column "file" is of type oid but expression is of type bytea