Re: Ordering of header file inclusion

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ordering of header file inclusion
Date: 2019-10-19 19:50:03
Message-ID: 5ef44524-371d-6036-8616-9f04df33c92b@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c
index f9fe57f..6224735 100644
--- a/contrib/bloom/blcost.c
+++ b/contrib/bloom/blcost.c
@@ -12,10 +12,10 @@
*/
#include "postgres.h"

+#include "bloom.h"
#include "fmgr.h"
#include "utils/selfuncs.h"

-#include "bloom.h"

/*
* Estimate cost of bloom index scan.

This class of change I don't like.

The existing arrangement keeps "other" header files separate from the
header file of the module itself. It seems useful to keep that separate.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-10-19 19:55:29 Re: Backport "WITH ... AS MATERIALIZED" syntax to <12?
Previous Message Ariadne Conill 2019-10-19 19:49:29 Re: jsonb_set() strictness considered harmful to data