| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | 'miyake_kouta' <miyake_kouta(at)oss(dot)nttdata(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench: improve \sleep meta command |
| Date: | 2021-03-08 15:54:18 |
| Message-ID: | 5dfd5662-b2aa-e060-79fc-ccca7cab89f4@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/03/08 23:10, Alvaro Herrera wrote:
> On 2021-Mar-08, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
>
>> Dear Fujii-san, Miyake-san
>>
>>> Isn't it better to accept even negative sleep time like currently pgbench does?
>>> Otherwise we always need to check the variable is a positive integer
>>> (for example, using \if command) when using it as the sleep time in \sleep
>>> command. That seems inconvenient.
>>
>> Both of them are acceptable for me.
>> But we should write down how it works when the negative value is input if we adopt.
>
> Not sleeping at all seems a good reaction (same as for zero, I guess.)
+1. BTW, IIUC currently \sleep works in that way.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2021-03-08 15:54:53 | Re: [PATCH] New default role allowing to change per-role/database settings |
| Previous Message | Fujii Masao | 2021-03-08 15:48:00 | Re: About to add WAL write/fsync statistics to pg_stat_wal view |