Re: backend type in log_line_prefix?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: backend type in log_line_prefix?
Date: 2020-03-15 10:32:31
Message-ID: 5d8f84b8-fc8d-0cb3-e887-32f7c7102c1b@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-03-13 22:24, Peter Eisentraut wrote:
> On 2020-03-10 19:07, Alvaro Herrera wrote:
>> I like these patches; the first two are nice cleanup.
>>
>> My only gripe is that pgstat_get_backend_desc() is not really a pgstat
>> function; I think it should have a different name with a prototype in
>> miscadmin.h (next to the enum's new location, which I would put
>> someplace near the "pmod.h" comment rather than where you put it;
>> perhaps just above the AuxProcType definition), and implementation
>> probably in miscinit.c.
>
> I have committed the refactoring patches with adjustments along these
> lines. The patch with the log_line_prefix and csvlog enhancements is
> still under discussion.

I have committed that last one also, after some corrections.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2020-03-15 10:34:20 Re: backend type in log_line_prefix?
Previous Message Justin Pryzby 2020-03-15 10:01:50 Re: Berserk Autovacuum (let's save next Mandrill)