Re: Add support for __attribute__((returns_nonnull))

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tristan Partin <tristan(at)neon(dot)tech>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add support for __attribute__((returns_nonnull))
Date: 2023-12-27 12:42:17
Message-ID: 5d6eab56-c7d8-46d7-bb37-6a9fc6269a0a@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.12.23 21:43, Tristan Partin wrote:
> Here is a patch which adds support for the returns_nonnull attribute
> alongside all the other attributes we optionally support.
>
> I recently wound up in a situation where I was checking for NULL return
> values of a function that couldn't ever return NULL because the
> inability to allocate memory was always elog(ERROR)ed (aborted).
>
> I didn't go through and mark anything, but I feel like it could be
> useful for people going forward, including myself.

I think it would be useful if this patch series contained a patch that
added some initial uses of this. That way we can check that the
proposed definition actually works, and we can observe what it does,
with respect to warnings, static analysis, etc.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-12-27 12:53:06 Re: pg_stat_statements: more test coverage
Previous Message Alexander Korotkov 2023-12-27 12:36:18 Re: Bug in nbtree optimization to skip > operator comparisons (or < comparisons in backwards scans)