Re: pgsql: Fix bug #16784 in Disk-based Hash Aggregation.

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <jdavis(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix bug #16784 in Disk-based Hash Aggregation.
Date: 2020-12-27 17:59:25
Message-ID: 5d34b38ab74e63695e977ed3a445ffa1f38bab78.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sun, 2020-12-27 at 02:09 -0500, Tom Lane wrote:
> Jeff Davis <jdavis(at)postgresql(dot)org> writes:
> > Fix bug #16784 in Disk-based Hash Aggregation.
>
> Buildfarm thinks this new test case is not completely stable.
>
> It appears that only 32-bit machines are failing, and it's
> not totally consistent even for them. Dunno what to make of it.

I think I just need to disable sort. Because there is a () group, we
don't need a Sort in the plan to exercise the bug.

Committed to master. I'll backport if the tests stabilize. I'm on
vacation now and will return on the 5th, so hopefully we're in a
reasonable state until then. If not, I can just revert my fix and deal
with it when I get back.

Regards,
Jeff Davis

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2020-12-27 20:11:50 pgsql: Second attempt to stabilize 05c02589.
Previous Message Jeff Davis 2020-12-27 17:53:01 pgsql: Stabilize test introduced in 05c02589, per buildfarm.