| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Michael Paquier" <michael(at)paquier(dot)xyz>, "Bharath Rupireddy" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | "Kyotaro Horiguchi" <horikyota(dot)ntt(at)gmail(dot)com>, "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add a perl function in Cluster.pm to generate WAL |
| Date: | 2023-12-20 03:24:04 |
| Message-ID: | 5d160064-8cbe-4b32-9c55-c983b1f63b12@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 19, 2023, at 8:00 PM, Michael Paquier wrote:
> On Tue, Dec 19, 2023 at 11:25:50AM +0530, Bharath Rupireddy wrote:
> > I used pg_logical_emit_message() in non-transactional mode without
> > needing an explicit WAL flush as the pg_switch_wal() does a WAL flush
> > at the end [1].
>
> Indeed, that should be enough to answer my comment.
>
> > Attached v4 patch.
>
> LGTM, thanks. Euler, what do you think?
>
LGTM.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-12-20 03:42:00 | Re: Synchronizing slots from primary to standby |
| Previous Message | Amit Kapila | 2023-12-20 03:11:12 | Re: Improve eviction algorithm in ReorderBuffer |