Re: [PATCH] Identify LWLocks in tracepoints

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Identify LWLocks in tracepoints
Date: 2021-04-29 07:31:54
Message-ID: 5d1150d8-aa88-414e-533a-d2aa97c76b68@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14.04.21 15:20, Peter Eisentraut wrote:
> On 12.04.21 07:46, Craig Ringer wrote:
>>      > To use systemtap semaphores (the _ENABLED macros) you need to run
>>     dtrace
>>      > -g to generate a probes.o then link that into postgres.
>>      >
>>      > I don't think we do that. I'll double check soon.
>>
>>     We do that.  (It's -G.)
>>
>>
>> Huh. I could've sworn we didn't. My mistake, it's there in
>> src/backend/Makefile .
>>
>> In that case I'll amend the patch to use semaphore guards.
>
> This whole thread is now obviously moved to consideration for PG15, but
> I did add an open item about this particular issue
> (https://wiki.postgresql.org/wiki/PostgreSQL_14_Open_Items, search for
> "dtrace").  So if you could produce a separate patch that adds the
> _ENABLED guards targeting PG14 (and PG13), that would be helpful.

Here is a proposed patch for this.

Attachment Content-Type Size
0001-Prevent-lwlock-dtrace-probes-from-unnecessary-work.patch text/plain 5.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-04-29 08:26:43 Re: Replication slot stats misgivings
Previous Message Amul Sul 2021-04-29 07:16:43 Re: Skip temporary table schema name from explain-verbose output.