From: | "Long Song" <songlong88(at)126(dot)com> |
---|---|
To: | "Kyotaro Horiguchi" <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re:Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll() |
Date: | 2024-06-04 10:03:17 |
Message-ID: | 5c1f3381.a0c0.18fe2b3fb21.Coremail.songlong88@126.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Kyotaro,
Thank you for the response.
At 2024-06-04 14:44:09, "Kyotaro Horiguchi" <horikyota(dot)ntt(at)gmail(dot)com> wrote:
>At Tue, 28 May 2024 20:15:59 +0800 (CST), "Long Song" <songlong88(at)126(dot)com> wrote in
>>
>> Hi,
>> Actually, I still wonder why only the error message
>> of the last failure to close the file was recorded.
>> For this unusual situation, it is acceptable to
>> record all failure information without causing
>> too much logging.
>> Was it designed that way on purpose?
>
>Note that SlruReportIOError() causes a non-local exit. To me, the
>point of the loop seems to be that we want to close every single file,
>apart from the failed ones. From that perspective, the patch disrupts
>that intended behavior by exiting in the middle of the loop. It seems
>we didn't want to bother collecting errors for every failed file in
>that part.
Yeah, thanks for your reminder.
It was my mistake not to notice the ereport() exit in the function.
But is it necessary to record it in a log? If there is a benefit to
logging, I can submit a modified patch and record the necessary
failure information into the log in another way.
>
>regards.
>
>--
>Kyotaro Horiguchi
>NTT Open Source Software Center
--
Best Regards,
Long
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-06-04 10:03:18 | Re: pgsql: Add more SQL/JSON constructor functions |
Previous Message | Alexander Lakhin | 2024-06-04 10:00:00 | Re: Recent 027_streaming_regress.pl hangs |