Re: run pgindent on a regular basis / scripted manner

On 2023-02-07 Tu 07:59, Magnus Hagander wrote:
>
>
> On Tue, Feb 7, 2023 at 1:56 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
>
> On Tue, Feb 7, 2023 at 5:16 PM Andrew Dunstan
> <andrew(at)dunslane(dot)net> wrote:
> >
> > On 2023-02-06 Mo 23:43, Noah Misch wrote:
> >
> >
> > Well, we did talk about adding a pre-commit hook to the
> repository, with
> > instructions for how to enable it. And I don't see a problem
> with adding the
> > pre-receive we're discussing here to src/tools/something.
> >
> > Yeah.  I don't think we are seriously considering putting any
> restrictions
> > in place on gitmaster
> >
> > I could have sworn that was exactly what we were discussing, a
> pre-receive
> > hook on gitmaster.
> >
> >
> > That's one idea that's been put forward, but it seems clear that
> some people are nervous about it.
> >
> > Maybe a better course would be to continue improving the toolset
> and get more people comfortable with using it locally and then
> talk about integrating it upstream.
> >
>
> Yeah, that sounds more reasonable to me as well.
>
>
> If we wanted something "in between" we could perhaps also have a async
> ci job that runs after each commit and sends an emali to the committer
> if the commit doesn't match up, instead of rejecting it hard but still
> getting some relatively fast feedback.

Sure, worth trying. We can always turn it off and no harm done if it
doesn't suit. I'd probably start by having it email a couple of guinea
pigs like you and me before turning it loose on committers generally.
LMK if you need help with it.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com