| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Parallel INSERT (INTO ... SELECT ...) |
| Date: | 2021-01-27 03:12:53 |
| Message-ID: | 5b6a6645a70e46d68f1784e7e627dfec@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
When testing the patch with the following kind of sql.
---
Insert into part_table select 1;
Insert into part_table select generate_series(1,10000,1);
Insert into part_table select * from testfunc();
---
we usually use these sqls to initialize the table or for testing purpose.
Personally I think we do not need to do the parallel safety-check for these cases,
because there seems no chance for the select part to consider parallel.
I thought we aim to not check the safety unless parallel is possible.
, So I was thinking is it possible to avoid the check it these cases ?
I did some quick check on the code, An Immature ideal is to check if there is RTE_RELATION in query.
If no we do not check the safety-check.
I am not sure is it worth to do that, any thoughts ?
Best regards,
Houzj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-01-27 03:13:24 | Re: [PATCH] remove pg_standby |
| Previous Message | Joel Jacobson | 2021-01-27 03:11:08 | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |