Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Bharath Rupireddy" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove duplicate static function check_permissions in slotfuncs.c and logicalfuncs.c
Date: 2021-09-12 16:46:35
Message-ID: 5b631883-a23a-458c-a8a3-63d344b0df7c@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 11, 2021, at 5:28 AM, Bharath Rupireddy wrote:
> We have two static check_permissions functions (one in slotfuncs.c
> another in logicalfuncs.c) with the same name and same code for
> checking the privileges for using replication slots. Why can't we have
> a single function CheckReplicationSlotPermissions in slot.c? This way,
> we can get rid of redundant code. Attaching a patch for it.
Good catch! Your patch looks good to me.

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Borodin 2021-09-12 17:00:11 Re: Private Information Retrieval (PIR) as a C/C++ Aggregate Extension
Previous Message Jaime Casanova 2021-09-12 16:26:00 Re: Schema variables - new implementation for Postgres 15