Re: Allow pg_archivecleanup to remove backup history files

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow pg_archivecleanup to remove backup history files
Date: 2023-05-09 13:32:59
Message-ID: 5adce8cd5ad2269fe687d2d56a341c88@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Horiguchi-san, Michael-san

Thanks for your comments and information!

Attached a patch with documentation and regression tests.

On 2023-04-26 06:39, Michael Paquier wrote:
> On Tue, Apr 25, 2023 at 05:29:48PM +0900, Kyotaro Horiguchi wrote:
>> I thought that we have decided not to do that, but I coundn't find any
>> discussion about it in the ML archive. Anyway, I think it is great
>> that we have that option.
>
> No objections from here to make that optional. It's been argued for a
> couple of times that leaving the archive history files is good for
> debugging, but I can also get why one would one to clean up all the
> files older than a WAL retention policy. Even if these are just few
> bytes, it can be noisy for the eye to see a large accumulation of
> history files mixed with the WAL segments.
> --
> Michael

--
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Attachment Content-Type Size
v2-0001-Allow-pg_archivecleanup-to-remove-backuphistoryfile.patch text/x-diff 5.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message 盏一 2023-05-09 14:12:28 Re: Proposal for Prototype Implementation to Enhance C/C++ Interoperability in PostgreSQL
Previous Message Tomas Vondra 2023-05-09 12:54:31 Re: Add LZ4 compression in pg_dump